Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canonical header form in default header matcher. #369

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Use canonical header form in default header matcher. #369

merged 1 commit into from
Apr 19, 2017

Conversation

tamalsaha
Copy link
Collaborator

@tamalsaha tamalsaha commented Apr 19, 2017 •
edited
Loading

  • I also removed strings.ToLower(), since metadata method itself performs this transformation for http/2.
  • This will also strip Grpc-Metadata- prefix regardless of the original casing used in http header.

@tmc
Copy link
Collaborator

tmc commented Apr 19, 2017

ci failure

@tamalsaha
Copy link
Collaborator Author

Fixed ci

@tamalsaha
Copy link
Collaborator Author

Code that shows that metdata.Pairs() encoded keys to lower case.
https://github.com/grpc/grpc-go/blob/master/metadata/metadata.go#L110
https://github.com/grpc/grpc-go/blob/master/metadata/metadata.go#L53

@tmc tmc merged commit 55d0969 into grpc-ecosystem:master Apr 19, 2017
tmc pushed a commit to tmc/grpc-gateway that referenced this pull request May 12, 2017
@tamalsaha @tmc
Use canonical header form in default header matcher. (grpc-ecosystem#369
ff85230 
)
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
@tamalsaha @tmc
Use canonical header form in default header matcher. (grpc-ecosystem#369
bb772e5 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmc tmc tmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamalsaha @tmc