Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly respect file flag for protoc-gen-swagger #293

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

tmc
Copy link
Collaborator

@tmc tmc commented Jan 9, 2017

No description provided.

f, _ = os.Open("input.txt")
if *file != "-" {
var err error
f, err = os.Open(*file)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not f, err := os.Open(*file)? without the var on the above line? Is there variable shadowing I'm missing here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achew that would define a new f instead of assigning to the one created previously.

@achew22
Copy link
Collaborator

achew22 commented Jan 21, 2018

The error is main_test.go:118: Test 0: file misparsed, expected 'stdin', got '-'. That can be fixed by editing

checkFlags(false, "stdin", "", t, 0)
to be - instead of stdin.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@achew22 achew22 merged commit 424b8e1 into grpc-ecosystem:master Feb 16, 2018
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants