-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-openapiv2 generating the wrong schema fixing the issue #2635 #2769
Conversation
Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the build error as well please
where can I see the build error? its now showing up for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just a few whitespace fixes left!
Looks like you need to pull |
Hi @lakshkeswani, I want to make a new release soon, would you have time to rebase this change on master and regenerate the files? |
References to other Issues or PRs
This PR Fixes the issue #2635
Have you read the Contributing Guidelines?
YES
Brief description of what is fixed or changed
Removed the duplication of required elements in the object schema by comparing it with the field schema only adding the unique ones .
Set the required array nil of field schema form swagger properties this is not required.
what is changed in the code?
Added the
getUniqueFields
method that will return the schema of unique fields.simply append the unique one to the field schema.
Other comments