protoc-gen-{grpc-gateway,openapiv2}: add optional support#1988
Closed
glerchundi wants to merge 1 commit intogrpc-ecosystem:masterfrom
Closed
protoc-gen-{grpc-gateway,openapiv2}: add optional support#1988glerchundi wants to merge 1 commit intogrpc-ecosystem:masterfrom
glerchundi wants to merge 1 commit intogrpc-ecosystem:masterfrom
Conversation
glerchundi
force-pushed
the
support-optional
branch
from
4a0ba31 to
1867e34
Compare
Let `protoc` know that these generators support optional keywords. This is by no means an implementation in `grpc-gateway` of the optional aware generated code, it's just shielding of being considered as blockers in code generation workflows. Closes grpc-ecosystem#1278
glerchundi
force-pushed
the
support-optional
branch
from
1867e34 to
2c5aed6
Compare
Collaborator
|
Hi Gorka, much appreciated, but this is being handled in #1951. Turns out there are some logical changes we wanted to make. |
Contributor
Author
|
Sure, no worries it was just a rebase from the last time. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let
protocknow that these generators support optional keywords. Thisis by no means an implementation in
grpc-gatewayof the optional awaregenerated code, it's just shielding of being considered as blockers in
code generation workflows.
Closes #1278