Bazel build with disable_global flag to use generated .pb.go as is #1859
Conversation
The command used was: bazel run gazelle -- update-repos -from_file=go.mod -to_macro=repositories.bzl%go_repositories --build_file_proto_mode=disable_global
| # gazelle:go_grpc_compilers //:go_apiv2, //:go_grpc, //protoc-gen-grpc-gateway:go_gen_grpc_gateway | ||
|
|
||
| proto_library( |
There was a problem hiding this comment.
Won't users in not-go sill need to depend on the proto_library?
There was a problem hiding this comment.
It looks like having both proto_library and and go_library would cause some build warning with Gazelle command. If there is a way to keep both, I agree that would be ideal - but I'm not sure how to achieve that 😥
|
I have now turned off openapi build - this is definitely less than ideal, and we probably need some setup that can pull in .proto as they are. Need to research more on what can be done to achieve build to use |
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
=======================================
Coverage 58.07% 58.07%
=======================================
Files 34 34
Lines 3754 3754
=======================================
Hits 2180 2180
Misses 1301 1301
Partials 273 273 Continue to review full report at Codecov.
|
|
Closing as I got a workaround for this from consuming code. |
References to other Issues or PRs
Fixes #1847
Brief description of what is fixed or changed
Disable proto generation from Bazel, and rely on generated code