Merge v2 into master #1731

johanbrandhorst · 2020-10-08T12:13:08Z

Draft change of merging v2 into master. Probably have to freeze v2 and master from now until I can merge this. I'm going to come back to this and update things that are missing/incorrect before we can make the release.

Fixes #1223

As previously attempted on v1, so it shall be on v2. We want to minimize the public API surface to more easily allow changes that won't break users.

ADOPTERS.md is modeled after the OPA ADOPTERS.md: https://github.com/open-policy-agent/opa/blob/master/ADOPTERS.md

The token belongs to a user with no membership anywhere, and it is limited to only reading github packages.

Replace with internal copy of CamelCase

Following on from #1242, this replace the StreamError with a status.Status type. Also, remove the ability to configure the stream error handler. The existing handler was specific to the old type, and we can add something better back in later if necessary. Fixes #1098

… parameters (#1267) * Added function nestedQueryParams with map[string] parameter for keeping track of and detecting circular references. Added test TestMessageToQueryParametersRecursive for testing gracefully handling of circular references between messages. See issue #1167 * Code-review change requests accepted * More missed circle references changed to cycle Fixes #1167

* httpbody in stream * httpbody contenttype in stream response * compare content type in test * Update examples/internal/integration/integration_test.go Co-authored-by: Johan Brandhorst <[email protected]> * httpbody readme update Co-authored-by: Johan Brandhorst <[email protected]>

Use half of the Circle runners resources.

All unary and streaming error responses are now handled with a single function each, and are configured in a single place.

codecov-io · 2020-10-10T14:45:50Z

Codecov Report

Merging #1731 into master will increase coverage by 5.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
+ Coverage   53.38%   58.74%   +5.36%     
==========================================
  Files          42       33       -9     
  Lines        3902     3624     -278     
==========================================
+ Hits         2083     2129      +46     
+ Misses       1562     1237     -325     
- Partials      257      258       +1

Impacted Files	Coverage Δ
internal/codegenerator/parse_req.go	`100.00% <ø> (ø)`
internal/descriptor/grpc_api_configuration.go	`27.27% <ø> (ø)`
internal/descriptor/openapi_configuration.go	`30.00% <ø> (ø)`
internal/descriptor/registry.go	`64.22% <ø> (ø)`
internal/descriptor/services.go	`74.48% <ø> (ø)`
internal/descriptor/types.go	`50.44% <ø> (ø)`
internal/httprule/compile.go	`100.00% <ø> (ø)`
internal/httprule/parse.go	`85.71% <ø> (ø)`
internal/httprule/types.go	`100.00% <ø> (ø)`
...-gen-grpc-gateway/internal/gengateway/generator.go	`40.54% <ø> (-0.03%)`	⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c3950...d4e62de. Read the comment docs.

ivucica · 2020-10-10T20:31:21Z

Everything else is now green except CLA for @kentdotn and @odsod. Manual check by entering the username also gives me a red warning.

Kent, did you use the exact same username to submit the CLA?

FTR the emails that PR tool sees are [email protected] and [email protected] [mangled] and the usernames as above. I will open an internal bug for @kentdotn straight away.

odsod · 2020-10-10T20:34:05Z

I've signed the CLA just now - should be all good on my end!

ivucica · 2020-10-10T20:46:04Z

I believe the issue is that PR #1446 had a gmail.com address for @kentdotn, while the CLA bot sees the default github.com noreply address.

For @odsod in PR #1504, there was an einride.tech address.

The new patches in this PR have different addresses for some reason? I'll file this as an edge case that could be supported.

ivucica · 2020-10-10T20:51:52Z

@googlebot please be nice and recheck (though I fully expect you'll fail).

I'd like to let authors of the bot take a look at this by Tuesday afternoon GMT, and after that I'll flip the flag manually. The CLAs were in place when the PRs were submitted (the bot said so!), the authors said they've signed CLAs here in this thread, hence it's reasonable to proceed with "this is fine".

google-cla · 2020-10-10T20:53:22Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

ivucica · 2020-10-12T16:33:24Z

@kentdotn Looks like your registration with the gmail.com address has Github username https://github.com/kentdotn (with the prefix). I'm told that preventing this will be implemented in future.

Can you fix the username? I'm told you may need to revoke and re-sign your CLA. If you're asked about the username, make sure you enter just kentdotn.

kentdotn · 2020-10-12T20:57:53Z

@googlebot I fixed it.

google-cla · 2020-10-12T20:58:17Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

kentdotn · 2020-10-12T20:58:35Z

@googlebot I consent.

google-cla · 2020-10-12T21:00:23Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-12T21:00:23Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-12T21:01:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

kentdotn · 2020-10-12T21:12:29Z

@ivucica I've changed username field in Edit Contact Information page but It seems it doesn't fix the situation.
Do you know how to revoke the contract? I couldn't find such buttons or links in https://cla.developers.google.com/clas or Edit Contact Information.

ivucica · 2020-10-13T13:31:32Z

@kentdotn It's actually all green on CLA bot's side. Your change did the trick. What I don't understand is why, despite all signals being green, the final result is still 'needs author consent'. I'll file a new bug.

@googlebot run the check again, please.

google-cla · 2020-10-13T13:34:18Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ivucica · 2020-10-13T13:35:53Z

I'm flipping the bit.

google-cla · 2020-10-13T13:39:22Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

johanbrandhorst and others added 30 commits April 29, 2020 09:26

Minimize public API

f75e6a7

As previously attempted on v1, so it shall be on v2. We want to minimize the public API surface to more easily allow changes that won't break users.

Add user testimonials and ADOPTERS.md

794b736

ADOPTERS.md is modeled after the OPA ADOPTERS.md: https://github.com/open-policy-agent/opa/blob/master/ADOPTERS.md

Add Chef to ADOPTERS.md

71a236d

Add Scaleway to ADOPTERS.md

269c812

Use public key to authenticate for docker registry

79d5250

The token belongs to a user with no membership anywhere, and it is limited to only reading github packages.

Remove uses of protoc-gen-go/generator

bacf8a9

Replace with internal copy of CamelCase

Add more instructions on the GitHub releases UI

246b6f8

Update dependency io_bazel_rules_go to v0.22.4

5694672

Update golang Docker tag to v1.14.2

80addb2

Update google.golang.org/genproto commit hash to 43844f6

fcfdaa0

Update module golang/protobuf to v1.4.1

141e1d8

Update dependency bazel_gazelle to v0.20.0

736daf8

Update golang.org/x/oauth2 commit hash to bf48bf1

72ab468

Update dependency com_github_bazelbuild_buildtools to v0.29.0

562dd79

Update module google.golang.org/grpc to v1.29.1

d2a144d

Update dependency com_github_bazelbuild_buildtools to v3

9834258

Update module antihax/optional to v1

6f6f7bb

Add bazel CI caching

8ce6067

Further tweak bazel resource limits

2a15025

Use half of the Circle runners resources.

Consolidate error handling configuration

029cfe8

All unary and streaming error responses are now handled with a single function each, and are configured in a single place.

Improved docs/_docs/season_of_docs.md (v2) (#1319)

fe53821

fixed typo in docs/_docs/usage.md in v2 branch (#1320)

3e4dfad

Renovate: run go mod tidy after updates

f189ce7

Update google.golang.org/genproto commit hash to 09dca8e

9f52fd1

Update dependency io_bazel_rules_go to v0.23.0

448189f

Update dependency bazel_gazelle to v0.21.0

77f9ac8

runtime: rewrite query.go in new protoreflect

43ced79

ivucica added cla: yes cla: no and removed cla: no cla: yes labels Oct 13, 2020

google-cla bot added cla: no and removed cla: yes labels Oct 13, 2020

ivucica added cla: yes and removed cla: no labels Oct 13, 2020

johanbrandhorst merged commit 26104fd into master Oct 14, 2020

johanbrandhorst deleted the merge-v2 branch October 14, 2020 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge v2 into master #1731

Merge v2 into master #1731

johanbrandhorst commented Oct 8, 2020

codecov-io commented Oct 10, 2020

ivucica commented Oct 10, 2020

odsod commented Oct 10, 2020

ivucica commented Oct 10, 2020 •

edited

Loading

ivucica commented Oct 10, 2020

google-cla bot commented Oct 10, 2020

ivucica commented Oct 12, 2020

kentdotn commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

kentdotn commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

kentdotn commented Oct 12, 2020

ivucica commented Oct 13, 2020

google-cla bot commented Oct 13, 2020

ivucica commented Oct 13, 2020

google-cla bot commented Oct 13, 2020

Merge v2 into master #1731

Merge v2 into master #1731

Conversation

johanbrandhorst commented Oct 8, 2020

codecov-io commented Oct 10, 2020

Codecov Report

ivucica commented Oct 10, 2020

odsod commented Oct 10, 2020

ivucica commented Oct 10, 2020 • edited Loading

ivucica commented Oct 10, 2020

google-cla bot commented Oct 10, 2020

ivucica commented Oct 12, 2020

kentdotn commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

kentdotn commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

kentdotn commented Oct 12, 2020

ivucica commented Oct 13, 2020

google-cla bot commented Oct 13, 2020

ivucica commented Oct 13, 2020

google-cla bot commented Oct 13, 2020

ivucica commented Oct 10, 2020 •

edited

Loading