Switch to new Go protobuf generators #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
upgrade-protoc-gen-go-protoc-gen-go-grpc
branch
from
f7b3404
to
3878da8
Compare
johanbrandhorst
force-pushed
the
upgrade-protoc-gen-go-protoc-gen-go-grpc
branch
4 times, most recently
from
34bc653
to
07e4bd3
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #1419 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 32 32
Lines 3895 3895
=======================================
Hits 2297 2297
Misses 1344 1344
Partials 254 254 Continue to review full report at Codecov.
|
johanbrandhorst
force-pushed
the
upgrade-protoc-gen-go-protoc-gen-go-grpc
branch
4 times, most recently
from
6470f21
to
0fe3efa
Compare
|
This is actually working as is, but the bazel side of things is still using the old generator, which is no good, so I'm going to try definine some new |
johanbrandhorst
force-pushed
the
upgrade-protoc-gen-go-protoc-gen-go-grpc
branch
from
0fe3efa
to
6b1cc13
Compare
johanbrandhorst
commented
May 28, 2020
| @@ -8,14 +8,24 @@ package(default_visibility = ["//visibility:public"]) | |||
| # TODO(yannic): Add examples/tests that use import_prefix/strip_import_prefix. | |||
|
|
|||
| # gazelle:exclude a_bit_of_everything.pb.gw.go | |||
| # gazelle:exclude a_bit_of_everything_grpc.pb.go | |||
There was a problem hiding this comment.
This is still a bit of a hack, see bazel-contrib/bazel-gazelle#798
johanbrandhorst
force-pushed
the
upgrade-protoc-gen-go-protoc-gen-go-grpc
branch
from
6b1cc13
to
c3ee7c7
Compare
Switch from github.com/golang/protobuf/protoc-gen-go to google.golang.org/protobuf/cmd/protoc-gen-go and google.golang.org/grpc/cmd/protoc-gen-go-grpc. Add APIv2 protoc-gen-go and protoc-gen-go-grpc bazel rules
johanbrandhorst
force-pushed
the
upgrade-protoc-gen-go-protoc-gen-go-grpc
branch
from
c3ee7c7
to
88c0bef
Compare
johanbrandhorst
commented
May 29, 2020
Comment on lines
+29
to
+82
|
|
||
| go_proto_compiler( | ||
| name = "go_apiv2", | ||
| options = [ | ||
| "paths=source_relative", | ||
| ], | ||
| plugin = "@org_golang_google_protobuf//cmd/protoc-gen-go", | ||
| suffix = ".pb.go", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "@com_github_golang_protobuf//proto:go_default_library", | ||
| "@io_bazel_rules_go//proto/wkt:any_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:api_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:compiler_plugin_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:descriptor_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:duration_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:empty_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:field_mask_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:source_context_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:struct_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:timestamp_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:type_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:wrappers_go_proto", | ||
| "@org_golang_google_protobuf//reflect/protoreflect:go_default_library", | ||
| "@org_golang_google_protobuf//runtime/protoimpl:go_default_library", | ||
| ], | ||
| ) | ||
|
|
||
| go_proto_compiler( | ||
| name = "go_grpc", | ||
| options = [ | ||
| "paths=source_relative", | ||
| ], | ||
| plugin = "@org_golang_google_grpc_cmd_protoc_gen_go_grpc//:protoc-gen-go-grpc", | ||
| suffix = "_grpc.pb.go", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "@io_bazel_rules_go//proto/wkt:any_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:api_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:compiler_plugin_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:descriptor_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:duration_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:empty_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:field_mask_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:source_context_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:struct_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:timestamp_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:type_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:wrappers_go_proto", | ||
| "@org_golang_google_grpc//:go_default_library", | ||
| "@org_golang_google_grpc//codes:go_default_library", | ||
| "@org_golang_google_grpc//status:go_default_library", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
I've raised bazel-contrib/rules_go#2522 to have these merged upstream
johanbrandhorst
commented
May 29, 2020
| @@ -28,6 +28,8 @@ import ( | |||
| var uuidgen = fastuuid.MustNewGenerator() | |||
|
|
|||
| type _ABitOfEverythingServer struct { | |||
| examples.UnimplementedABitOfEverythingServiceServer | |||
| examples.UnimplementedStreamServiceServer | |||
There was a problem hiding this comment.
These will eventually be required by protoc-gen-go-grpc, so I'm adding them now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from github.com/golang/protobuf/protoc-gen-go
to google.golang.org/protobuf/cmd/protoc-gen-go
and google.golang.org/grpc/cmd/protoc-gen-go-grpc.
Add APIv2 protoc-gen-go and protoc-gen-go-grpc bazel rules