Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1098: remove error field from error messages #1242

Merged
merged 8 commits into from
Apr 28, 2020
Merged

#1098: remove error field from error messages #1242

merged 8 commits into from
Apr 28, 2020

Commits on Apr 26, 2020

  1. runtime/errors: remove 'error' field, use gRPC status instead 

    Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    08177fb View commit details
    Browse the repository at this point in the history

  2. internal/errors.proto: regenerate 

    Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    263253a View commit details
    Browse the repository at this point in the history

  3. protoc-gen-swagger: use google.rpc.Status instead of .grpc.gateway.ru… 

    …ntime.Error

Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    4775173 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. protoc-gen-swagger: rename AddStreamError -> AddErrorDefs, add to tests 

    There are probably better ways to write this in than calling
`AddErrorDefs` everywhere.

Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    166f49a View commit details
    Browse the repository at this point in the history

  2. rebuild all the things 

    Note: I've also run

    find examples -name "*runtime_error*" -delete

before. It seems like those are not captured by any of the *clean make
targets.

Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    a641c87 View commit details
    Browse the repository at this point in the history

  3. run "bazel run :gazelle" 

    Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    a416b83 View commit details
    Browse the repository at this point in the history

  4. runtime/errors: fix comment, use status.Convert 

    Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    1f689cb View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. integration_test: port error status test to proto_error_test.go 

    Signed-off-by: Stephan Renatus <[email protected]>
    @srenatus
    srenatus committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    2aaabe5 View commit details
    Browse the repository at this point in the history