Replace glog with grpclog #118
Conversation
| @@ -82,7 +82,7 @@ func (s *ServeMux) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| for _, h := range s.handlers[r.Method] { | |||
| pathParams, err := h.pat.Match(components, verb) | |||
| if err != nil { | |||
| glog.V(3).Infof("path mismatch: %q to %q", path, h.pat) | |||
| grpclog.Printf("path mismatch: %q to %q", path, h.pat) | |||
There was a problem hiding this comment.
This log is too verbose to always record. Let's remove it.
|
@cuongdo Thank you. |
cuongdo
force-pushed
the
replace_glog_with_grpclog
branch
from
7f8d017
to
718c9c5
Compare
|
Thank you for your fast response. I've made the changes you suggested. Review status: 0 of 10 files reviewed at latest revision, 5 unresolved discussions. runtime/mux.go, line 85 [r1] (raw file): runtime/pattern.go, line 147 [r1] (raw file): runtime/pattern.go, line 163 [r1] (raw file): runtime/pattern.go, line 169 [r1] (raw file): runtime/pattern.go, line 194 [r1] (raw file): Comments from the review on Reviewable.io |
cuongdo
force-pushed
the
replace_glog_with_grpclog
branch
from
718c9c5
to
a297be7
Compare
This allows projects with forked versions of glog (e.g. CockroachDB) to use grpc-gateway without a flag collision on the glog flags.
cuongdo
force-pushed
the
replace_glog_with_grpclog
branch
from
a297be7
to
309f6cc
Compare
|
Also, I've removed the "Pattern successfully built" log message at the end of Review status: 0 of 10 files reviewed at latest revision, 5 unresolved discussions. Comments from the review on Reviewable.io |
|
LGTM. Thank you for your contribution. |
|
Great. Thanks for your very fast response! On Tue, Mar 1, 2016 at 6:37 PM Yuki Yugui Sonoda [email protected]
|
This allows projects with forked versions of
glog(e.g. CockroachDB) to usegrpc-gatewaywithout a flag collision (runtime panic) on theglogflags such as-logtostderr. This also allows integration with any logging systems that have been integrated withgrpclog.Note that I only replaced
glogin theruntimepackage and in the files generated byprotoc-gen-grpc-gateway. The use ofglogelsewhere in this repo doesn't seem to affect ability to usegrpc-gatewayin projects with forkedglogversions.Fixes #92.