Fix a goroutine-leak in HTTP keep-alive #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugui
changed the title
yugui
force-pushed
the
fix/goroutine-leak
branch
from
811d361
to
0de390c
Compare
|
LGTM. I'm using this branch in my env and confirmed it fixed goroutine leak. |
CloseNotifier channel is triggered only if the connection is closed, the goroutines for earlier requests used to remain until the last request closes the connection when HTTP keep-alive is used. This commit terminates the groutine as soon as its corresponding HTTP request is done.
yugui
force-pushed
the
fix/goroutine-leak
branch
from
a36fe31
to
6f975cf
Compare
yugui
added a commit
that referenced
this pull request
Mar 1, 2016
Fix a goroutine-leak in HTTP keep-alive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloseNotifierchannel is triggered only if the connection is closed,the goroutines for earlier requests used to remain until the last
request closes the connection when HTTP keep-alive is used.
This commit terminates the groutine as soon as its corresponding HTTP
request is done.
I'm not sure but it might fix #115.