Support reserved json name and add tests #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 53.84% 53.87% +0.03%
==========================================
Files 42 42
Lines 4175 4178 +3
==========================================
+ Hits 2248 2251 +3
Misses 1681 1681
Partials 246 246
Continue to review full report at Codecov.
|
…d of lowerCamelCase
johanbrandhorst
approved these changes
Nov 14, 2019
|
@johanbrandhorst , Thank you so much for reviewing! Anytime! |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* Support reserved json name and add tests * Correct some variable names * Optimize a logic for assigning a reserved json name to jsonCamelCaseName * Put a logic for checking if there is a reseved json name in the method of lowerCamelCase Fixes grpc-ecosystem#1084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support reserved JSON name and add tests.
Like: when a reserved JSON name is specified in protobuf, then the swagger doc will generate this reserved JSON name instead of a lower case camel variable name.
Ref: #1084