Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel incompatible changes #873

Closed
laurentlb opened this issue Feb 22, 2019 · 2 comments · Fixed by #874
Closed

Bazel incompatible changes #873

laurentlb opened this issue Feb 22, 2019 · 2 comments · Fixed by #874

Comments

@laurentlb
Copy link

It seems like the repository doesn't build with Bazel incompatible changes.
With --incompatible_disallow_old_style_args_add, we get:

	File "/usr/local/google/home/laurentlb/.cache/bazel/_bazel_laurentlb/59217ff323cdbf9f3c98b0d19e37510b/external/grpc_ecosystem_grpc_gateway/protoc-gen-swagger/defs.bzl", line 73, in depset
		_run_proto_gen_swagger(ctx, direct_proto_srcs = proto.dir..., <5 more arguments>)
	File "/usr/local/google/home/laurentlb/.cache/bazel/_bazel_laurentlb/59217ff323cdbf9f3c98b0d19e37510b/external/grpc_ecosystem_grpc_gateway/protoc-gen-swagger/defs.bzl", line 53, in _run_proto_gen_swagger
		args.add([("-I%s" % include) for include ...])
Args#add no longer accepts vectorized arguments when --incompatible_disallow_old_style_args_add is set. Please use Args#add_all or Args#add_joined.

One way to check whether it's compatible, and find the future breakages, is to use bazelisk, e.g.
bazelisk --migrate test //...

(cc @ensonic because https://github.com/googlecloudrobotics/core depends on this)

@johanbrandhorst
Copy link
Collaborator

Thanks for reporting this. I'll just CC some people that know better than I.

CC @drigz @achew22

@achew22
Copy link
Collaborator

achew22 commented Feb 22, 2019

bazelbuild/bazel-integration-testing#108 needs to be merged then we can switch to it and it'll fix it.

@laurentlb thanks so much for doing this 😄

achew22 added a commit to achew22/grpc-gateway that referenced this issue Feb 23, 2019
achew22 added a commit that referenced this issue Feb 23, 2019
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants