Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to stdlib context over x/net/context #326

Closed
tmc opened this issue Mar 14, 2017 · 3 comments · Fixed by #596
Closed

Move to stdlib context over x/net/context #326

tmc opened this issue Mar 14, 2017 · 3 comments · Fixed by #596

Comments

@tmc
Copy link
Collaborator

tmc commented Mar 14, 2017

Placeholder issue.

We'll wait to do this until grpc/grpc-go#711 closes.
@tamalsaha
Copy link
Collaborator

cc: @sadlil

@tmc tmc mentioned this issue Mar 31, 2017
Closed
@AlekSi
Copy link
Contributor

AlekSi commented Oct 4, 2017

Not really required with Go 1.9 aliases.

@achew22
Copy link
Collaborator

achew22 commented Dec 14, 2017

Not really required, but I assume the x/net/context package will eventually go away so we should proably just do it.

@achew22 achew22 mentioned this issue Jan 26, 2018
Closed
achew22 added a commit to achew22/grpc-gateway that referenced this issue Apr 14, 2018
@achew22
Upgrade to go1.10 and regenerate
458ead3 
Go 1.10 makes the move to the new context automatically on `go fix` so

Fixes: grpc-ecosystem#326
@achew22 achew22 mentioned this issue Apr 14, 2018
Merged
achew22 added a commit that referenced this issue Apr 14, 2018
@achew22
Upgrade to go1.10 and regenerate
37660b1 
Go 1.10 makes the move to the new context automatically on `go fix` so

Fixes: #326
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
@achew22
Upgrade to go1.10 and regenerate
faa6b37 
Go 1.10 makes the move to the new context automatically on `go fix` so

Fixes: grpc-ecosystem#326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to go1.10 and regenerate achew22/grpc-gateway
4 participants
@tmc @AlekSi @achew22 @tamalsaha