Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recent annotation change requires req.RemoteAddr to be populated #177

Closed
tmc opened this issue Jun 7, 2016 · 1 comment
Closed

recent annotation change requires req.RemoteAddr to be populated #177

tmc opened this issue Jun 7, 2016 · 1 comment
Labels
bug

Comments

@tmc
Copy link
Collaborator

tmc commented Jun 7, 2016

a5edb0b merge resolution added grpclog.Printf("invalid remote addr: %s", req.RemoteAddr) which created a dependency on the incoming request that wasn't there before. Shouldn't the header just not be populated if RemoteAddr isn't present?
@yugui
Copy link
Member

yugui commented Jun 7, 2016

You are right. We need to fix that part.

@yugui yugui added the bug label Jun 7, 2016
yugui added a commit that referenced this issue Jun 7, 2016
@yugui
Avoid errors when req.RemoteAddr is empty
70580da 
Fixes #177
@yugui yugui mentioned this issue Jun 7, 2016
Merged
@yugui yugui closed this as completed in #178 Jun 7, 2016
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
@yugui
Avoid errors when req.RemoteAddr is empty
720326f 
Fixes grpc-ecosystem#177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmc @yugui