Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After the 1.7 release, update .travis.yaml to check the compiled proto output #137

Closed
achew22 opened this issue Apr 18, 2016 · 0 comments
Closed

After the 1.7 release, update .travis.yaml to check the compiled proto output #137

achew22 opened this issue Apr 18, 2016 · 0 comments

Comments

@achew22
Copy link
Collaborator

achew22 commented Apr 18, 2016

Go changed the way they encode gzip. This was causing the tests to break since you could only target either Go 1.5 or Tip. Once 1.7 comes out (and the gzip change is in 1.6.x) the check that prevents comparison on tip should be removed.
@achew22 achew22 closed this as completed Aug 9, 2016
yugui added a commit that referenced this issue Aug 16, 2016
@yugui
Upgrade Go version in Travis CI to 1.7
6f56d32 
* Regenerate .pb.go files with Go 1.7 -- c.f. #137
@yugui yugui mentioned this issue Aug 16, 2016
Closed
@tamalsaha tamalsaha mentioned this issue Mar 30, 2017
Closed
1 task
@hixio-mh hixio-mh mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achew22