Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-retry-attempt to StreamClientInterceptor #733

Merged
merged 2 commits into from
Nov 28, 2024
Merged

x-retry-attempt to StreamClientInterceptor #733

merged 2 commits into from
Nov 28, 2024

Conversation

Boklazhenko
Copy link
Contributor

Changes

add "x-retry-attempt" metadata to Retry StreamClientInterceptor

Verification

local testing

@Boklazhenko Boklazhenko mentioned this pull request Nov 27, 2024
Open
johanbrandhorst
johanbrandhorst requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the linter error, that's a false positive. Could you add some tests to our test sweet that exercises this code?

@Boklazhenko
Copy link
Contributor Author

Unit test added

johanbrandhorst
johanbrandhorst approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johanbrandhorst johanbrandhorst merged commit 6aea589 into grpc-ecosystem:main Nov 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Boklazhenko @johanbrandhorst