Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Fix: middleware chain order example #464

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

AmirQadir
Copy link
Contributor

In the chaining interceptor example, the recovery handler was the first element in the unary chain. It should have been last as per the recovery example in the codebase.

// Create a server. Recovery handlers should typically be last in the chain so that other middleware

// (e.g. logging) can operate on the recovered state instead of being directly affected by any panic

@google-cla
Copy link

google-cla bot commented Oct 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AmirQadir
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 18, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@AmirQadir
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit 560829f into grpc-ecosystem:master Oct 19, 2021
@xiaozhoz
Copy link

xiaozhoz commented Feb 8, 2023

I intend to put it in the first one since it can recover unexpected panic from other custom middlewares. See #414 also.

I didn't get how it affects other middlewares if recovery is the first one. Could you please explain more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants