Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve zap grpc logger documentation on verbosity levels #456

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Improve zap grpc logger documentation on verbosity levels #456

merged 1 commit into from
Sep 20, 2021

Conversation

chrisdoherty4
Copy link
Contributor

The documentation around verbosity levels for gRPC logging is unclear - this change aims to rectify that.

The original issue (#221) contains some conflating information regarding how to use the verbosity levels that people keep landing on.

@google-cla
Copy link

google-cla bot commented Sep 10, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@chrisdoherty4
Copy link
Contributor Author

@googlebot I signed it!

@yashrsharma44
Copy link
Collaborator

Hi @chrisdoherty4 , is it ready for review?

@chrisdoherty4
Copy link
Contributor Author

@yashrsharma44 yes. Its minor, I know. I just got frustrated having to dig into code when this simple comment would've answered my question.

@yashrsharma44 yashrsharma44 merged commit b6d97fa into grpc-ecosystem:master Sep 20, 2021
@yashrsharma44
Copy link
Collaborator

Thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants