grpc_zap: fix caller annotation #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `zapGrpcLoggerV2` wraps a zap's logger, caller annotations always point `grpclogger.go` instead of the expected file. This commit adds caller skip so that each log message has the correct annotation. This commit also upgrades zap's version to v1.18.1 to use `zap.OnFatal` in tests. That function is necessary to catch fatal level log messages.
jkawamoto
force-pushed
the
zap_caller_annotation
branch
from
a51d7c9 to
8f77c1f
Compare
johanbrandhorst
approved these changes
Jul 2, 2021
|
Thanks for your contribution! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
zapGrpcLoggerV2wraps a zap's logger, caller annotations always pointgrpclogger.goinstead of the expected file. This commit adds caller skip so that each log message has the correct annotation.This commit also upgrades zap's version to v1.18.1 to use
zap.OnFatalin tests. That function is necessary to catch fatal-level log messages.