Fix the special case for jaeger format traceid extraction #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idden regression introduced with grpc-ecosystem#262
johanbrandhorst
requested changes
Sep 17, 2020
|
I looked at doing that but couldn't spot a way to do it end-to-end, unless you're happy with just a test that calls the function directly? |
|
I think that'd be alright, just something to protect us from regressions and to show a case that was broken. |
|
Added. Any chance of having a look at PR #327 while you're at it? That one's been bugging me for a while, has a unit test already too. |
johanbrandhorst
approved these changes
Sep 17, 2020
|
Thanks for your contribution! Could you cherry pick this against the v2 branch please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #262 introduces a regression where special parsing for the jaeger format traceid extraction is overridden with the unparsed value later in the same file.
Where a header matches the traceHeaderName it is preferred over the other matching types using partial string matches.