Moved to GH actions; Added lint; Added issue/PR templates.

[bwplotka]

Also pinned Go tools thanks to https://github.com/bwplotka/bingo

Signed-off-by: Bartlomiej Plotka [email protected]

[bwplotka]

Let's make sure the CI GH actions runs here

[bwplotka]

TODO still GH err: https://github.com/grpc-ecosystem/go-grpc-middleware/actions/runs/119943153

[bwplotka]

Super thank your for awesome quick review, will address this afternoon! (:

[irridia]

Be sure to update the import paths in the examples_test files, both for users and it confuses go mod.

[bwplotka]

Good point, thanks

…

[bwplotka]

Lot's of vert / lint issue to go through...

[bwplotka]

Should be fine now, PTAL @yashrsharma44 @johanbrandhorst

[codecov-commenter]

Codecov Report

Merging #296 into v2 will decrease coverage by 4.65%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##               v2     #296      +/-   ##
==========================================
- Coverage   84.01%   79.35%   -4.66%     
==========================================
  Files          30       30              
  Lines         932      930       -2     
==========================================
- Hits          783      738      -45     
- Misses        110      150      +40     
- Partials       39       42       +3     

Impacted Files	Coverage Δ
chain.go	0.00% <ø> (-90.91%)	⬇️
interceptors/tags/fieldextractor.go	84.84% <ø> (-0.45%)	⬇️
interceptors/logging/payload.go	83.07% <50.00%> (+0.46%)	⬆️
interceptors/retry/retry.go	77.71% <100.00%> (-0.74%)	⬇️
wrappers.go	66.66% <0.00%> (-33.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2c2ac...c1c1b73. Read the comment docs.

[bwplotka]

Close to be finished.. two last standing thigs:

1. make lint works locally but not on GH Actions:

make[1]: Leaving directory '/home/runner/work/go-grpc-middleware/go-grpc-middleware'
cannot detected proto changes or other not formatted files
/bin/bash: run: command not found
M	grpctesting/gogotestpb/fields.pb.go
M	grpctesting/testpb/test.pb.go
Please commit or stash them.

This is super weird cannot detected proto changes or other not formatted files - looks like goimports does not format anything at the end 🤔

2. Flaky time based tests: FAIL: TestRetrySuite/TestServerStream_PerCallDeadline_Succeeds (0.54s)

Some work to either mock time or increase timeouts ... Will look tomorrow if you want to help feel free to propose PR to this PR @https://github.com/yashrsharma44 I have time off tomorrow kind of. (:

[irridia]

go mod behaves and I can import and use the logging. \o/

I feel your pain on the tests...

[bwplotka]

Should be good to go - will work on retry flakinesses in separate PR. @yashrsharma44 @johanbrandhorst (:

[yashrsharma44]

Thanks @bwplotka on working on this PR! I will try to make up for the lost time 🤓

[irridia]

Can you cut a new tag on branch v2, perhaps v2.0.0-rc.2? It'll make mod updates automatic-er.

[johanbrandhorst]

I've created a new release: https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0-rc.2

[yashrsharma44]

Hey @irridia! Can you share how did you correctly install v2 branch?

[irridia]

I've created a new release: https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0-rc.2

Thanks. Would you mind also creating a providers/zerolog/v2.0.0-rc.2 tag so that the zerolog portion of v2 is "released"? Also, if there were changes to the other log providers, individual tags for those would be a good idea IMHO.

[irridia]

Hey @irridia! Can you share how did you correctly install v2 branch?

Importing at the github.com/grpc-ecosystem/go-grpc-middleware/v2 path should trigger go mod tidy to see the "/v2" suffix and pull the latest tag from the repo of the form v2.*. In this case, that will be v2.0.0-rc.2.

Generally I just delete the line from go.mod, and run go mod tidy to re-perform the dependency match. Though sometimes I need to go clean -modcache.

The same method applies when separately importing the log providers at github.com/grpc-ecosystem/go-grpc-middleware/providers/zerolog/v2. Right now there are no latest tags for zerolog, so to import it (for now) you'd have to find the actual commit hash of the latest v2 merge (880c1749170035e5a54794546dbfe0d45d10a11d in this case) and add it manually to go.mod.

As an example, from a fresh go mod init ; go mod tidy, tidy will error out but it creates a go.mod file with this line:

  github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.2

Then to get zerolog (for example) importing, manually add this line to go mod:

  github.com/grpc-ecosystem/go-grpc-middleware/providers/zerolog/v2 880c1749170035e5a54794546dbfe0d45d10a11d

Once you run go mod tidy, go.mod will be rewritten as:

  github.com/grpc-ecosystem/go-grpc-middleware/providers/zerolog/v2 v2.0.0-rc.0.0.20200618173137-880c17491700
  github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.2

And cheat mode is just "add those two lines to your go.mod". ;-)

[yashrsharma44]

Thank you so much @irridia ! This was a pretty cool. I googled a lot to find similar issues, but I didn't get any. But the explanation was really awesome, thanks!

Edit :
I wonder why go get doesn't work in this case, seems weird

[johanbrandhorst]

I've created a new release: https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0-rc.2

Thanks. Would you mind also creating a providers/zerolog/v2.0.0-rc.2 tag so that the zerolog portion of v2 is "released"? Also, if there were changes to the other log providers, individual tags for those would be a good idea IMHO.

Done https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/providers%2Fzerolog%2Fv2.0.0-rc.2. I have only tagged zerolog.

[irridia]

Thanks! go mod init ; go mod tidy now does everything automatically with the .../v2 imports. I'll start rolling v2 into our services and see how it goes.

	github.com/grpc-ecosystem/go-grpc-middleware/providers/zerolog/v2 v2.0.0-rc.2
	github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.2