-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved imports to v2; Moved to Go 1.14.2 #290
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,10 @@ import ( | |
"testing" | ||
"time" | ||
|
||
"github.com/grpc-ecosystem/go-grpc-middleware/grpctesting" | ||
"github.com/grpc-ecosystem/go-grpc-middleware/v2/grpctesting" | ||
"google.golang.org/grpc/status" | ||
|
||
pb_testproto "github.com/grpc-ecosystem/go-grpc-middleware/grpctesting/testproto" | ||
pb_testproto "github.com/grpc-ecosystem/go-grpc-middleware/v2/grpctesting/testproto" | ||
Comment on lines
+14
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😱 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yea not formatted well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will fix in later PR |
||
"github.com/stretchr/testify/require" | ||
"github.com/stretchr/testify/suite" | ||
"google.golang.org/grpc" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What import grouping do we want to use? This is a little inconsistent. I usually do 3 import groups. Maybe now is a good time to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I use goimports which does 2 groups. What do you prefer? I am fine with whatever as long as there is popular auto formatting tool for this (: