Initial change for v2.

[bwplotka]

As per #275

The main goals are to have separate modules per each implementation and all reusing the same code.
This way we can ensure consistency, and we reduce LOC to a minimum, including tests.

Changes:

• Removed grpc_ prefix from all packages like grpc_middleware. Users can add them on their own.
• Moved all specific implementations to separate modules. The exception is opentracing, as opentracing itself
  is just an amazing interface, so.. perfect (:
• Added generic interceptor code that both monitoring, logging, and tracing will use under /interceptors
• Reuse generic interceptors in interceptor/{logging,tracing,metrics,tags}. This allows huge simplification of those.
• No context logger. Only ctxtags.Tags responsible for propagating tags in context and proto messages.
• Tags are now map[string]string to discourage context value abuse.
• PayloadUnary works as a standalone interceptor as well.
• Tags will actually use map tags instead of noop if not created.
• Added scripts for a proto generation.
• Let tag.Interceptor to extract request data for all types of requests.

New package structure:

├── auth
│   └── [util package for auth for gRPC]
├── chain.go
├── chain_test.go
├── CHANGELOG.md
├── CONTRIBUTING.md
├── doc.go
├── go.mod
├── go.sum
├── grpctesting
│   └── [util package for testing and test suite]
├── interceptors
│   ├── client.go [core package for all interceptors]
│   ├── client_test.go
│   ├── doc.go
│   ├── logging
│   │    └── [logging interceptor package allowing to inject Logger]
│   ├── ratelimit
│   │   └── [ratelimit interceptor]
│   ├── recovery
│   │   └── [panic recovery interceptor]
│   ├── reporter.go
│   ├── retry
│   │   └── [retry interceptor]
│   ├── server.go
│   ├── server_test.go
│   ├── tags
│   │   └── [interceptor allowing to inject and propagate string tags]
│   ├── tracing
│   │   └── [opentracing interceptor]
│   └── validator
│       └── [proto validation interceptor]
├── LICENSE
├── Makefile
├── providers [All implementations for our interfaces for each provider. Always separate modules]
│   ├── kit
│   │   ├── examples_test.go
│   │   ├── go.mod
│   │   ├── go.sum
│   │   └── logger.go
│   ├── logrus
│   │   ├── examples_test.go
│   │   ├── go.mod
│   │   ├── go.sum
│   │   └── logger.go
│   └── zap
│       ├── examples_test.go
│       ├── go.mod
│       ├── go.sum
│       └── logger.go
├── README.md
├── scripts
├── util
│   └── [utils]
├── wrappers.go
└── wrappers_test.go

21 directories, 98 files

Signed-off-by: Bartlomiej Plotka [email protected]

[bwplotka]

Hi, I know it's a huge change, but I believe it's ready to go.

Missing unit test for zap,logrus,kit, but will add later. The implementation are ridiculously small now.

Happy to schedule some call with you @domgreen @johanbrandhorst to go through this! 💪

@domgreen @johanbrandhorst

[codecov-io]

Codecov Report

Merging #276 into v2 will increase coverage by 10.03%.
The diff coverage is 85.34%.

@@             Coverage Diff             @@
##               v2     #276       +/-   ##
===========================================
+ Coverage   73.54%   83.58%   +10.03%     
===========================================
  Files          42       30       -12     
  Lines        1580      932      -648     
===========================================
- Hits         1162      779      -383     
+ Misses        365      114      -251     
+ Partials       53       39       -14

Impacted Files	Coverage Δ
wrappers.go	100% <ø> (ø)	⬆️
interceptors/recovery/interceptors.go	100% <ø> (ø)
interceptors/retry/retry.go	76.24% <ø> (ø)
interceptors/tags/options.go	100% <ø> (ø)
auth/metadata.go	100% <ø> (ø)	⬆️
interceptors/tracing/options.go	73.68% <ø> (ø)
util/metautils/nicemd.go	91.66% <ø> (ø)	⬆️
interceptors/retry/backoff.go	50% <ø> (ø)
interceptors/retry/options.go	80.48% <ø> (ø)
interceptors/recovery/options.go	78.57% <ø> (ø)
... and 30 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce3d51...dfb47b3. Read the comment docs.

[johanbrandhorst]

I think this was probably a mistake?

[bwplotka]

yes, but also does not matter, does it? Technically we are talking about tags..

Thanks for review!