Moved the constants to interceptor package

Signed-off-by: Yash Sharma <[email protected]>
grpc-ecosystem · Jan 15, 2021 · d476f2f · d476f2f
1 parent 60b2d64
commit d476f2f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/interceptors/reporter.go b/interceptors/reporter.go
@@ -40,6 +40,13 @@ func (tm *DefaultTimer) ObserveDuration() time.Duration {
 
 var EmptyTimer = &noOpTimer{}
 
+type RPCMethod string
+
+const (
+	Send    RPCMethod = "send"
+	Receive RPCMethod = "recv"
+)
+
 const (
 	Unary        GRPCType = "unary"
 	ClientStream GRPCType = "client_stream"

diff --git a/providers/prometheus/constants.go b/providers/prometheus/constants.go
@@ -15,10 +15,3 @@ const (
 	KindClient Kind = "client"
 	KindServer Kind = "server"
 )
-
-type RPCMethod string
-
-const (
-	Send    RPCMethod = "send"
-	Receive RPCMethod = "recv"
-)
diff --git a/providers/prometheus/interceptors.go b/providers/prometheus/interceptors.go
@@ -23,12 +23,12 @@ func (r *reporter) StartTimeCall(startTime time.Time, callType string) intercept
 	switch r.kind {
 	case KindClient:
 		switch callType {
-		case string(Send):
+		case string(interceptors.Send):
 			if r.clientMetrics.clientStreamSendHistogramEnabled {
 				hist := r.clientMetrics.clientStreamSendHistogram.WithLabelValues(string(r.typ), r.service, r.method)
 				return prometheus.NewTimer(hist)
 			}
-		case string(Receive):
+		case string(interceptors.Receive):
 			if r.clientMetrics.clientStreamRecvHistogramEnabled {
 				hist := r.clientMetrics.clientStreamRecvHistogram.WithLabelValues(string(r.typ), r.service, r.method)
 				return prometheus.NewTimer(hist)

diff --git a/providers/prometheus/options.go b/providers/prometheus/options.go
@@ -9,7 +9,7 @@ import (
 func FromError(err error) (s *status.Status, ok bool) {
 	return status.FromError(err)
 
-	// TODO: @yashrsharma - discuss if we require more error handling from the previous package
+	// TODO: @yashrsharma44 - discuss if we require more error handling from the previous package
 }
 
 // A CounterOption lets you add options to Counter metrics using With* funcs.