Added a new prometheus provider

Signed-off-by: Yash Sharma <[email protected]>
grpc-ecosystem · Jan 15, 2021 · 0434dfb · 0434dfb
1 parent a365913
commit 0434dfb
Show file tree

Hide file tree

Showing 8 changed files with 465 additions and 59 deletions.
diff --git a/interceptors/metrics/metrics_interface.go b/interceptors/metrics/metrics_interface.go
diff --git a/interceptors/metrics/client_metrics.go → providers/prometheus/client_metrics.go b/interceptors/metrics/client_metrics.go → providers/prometheus/client_metrics.go
diff --git a/providers/prometheus/constants.go b/providers/prometheus/constants.go
@@ -0,0 +1,24 @@
+package metrics
+
+type grpcType string
+
+const (
+	Unary        grpcType = "unary"
+	ClientStream grpcType = "client_stream"
+	ServerStream grpcType = "server_stream"
+	BidiStream   grpcType = "bidi_stream"
+)
+
+type Kind string
+
+const (
+	KindClient Kind = "client"
+	KindServer Kind = "server"
+)
+
+type RPCMethod string
+
+const (
+	Send    RPCMethod = "send"
+	Receive RPCMethod = "recv"
+)
diff --git a/providers/prometheus/go.mod b/providers/prometheus/go.mod
@@ -0,0 +1,9 @@
+module github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus
+
+go 1.15
+
+require (
+	github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.2
+	github.com/prometheus/client_golang v1.9.0
+	google.golang.org/grpc v1.35.0
+)
diff --git a/providers/prometheus/go.sum b/providers/prometheus/go.sum
diff --git a/interceptors/metrics/interceptors.go → providers/prometheus/interceptors.go b/interceptors/metrics/interceptors.go → providers/prometheus/interceptors.go
@@ -23,12 +23,12 @@ func (r *reporter) StartTimeCall(startTime time.Time, callType string) intercept
 	switch r.kind {
 	case KindClient:
 		switch callType {
-		case "send":
+		case string(Send):
 			if r.clientMetrics.clientStreamSendHistogramEnabled {
 				hist := r.clientMetrics.clientStreamSendHistogram.WithLabelValues(string(r.typ), r.service, r.method)
 				return prometheus.NewTimer(hist)
 			}
-		case "recv":
+		case string(Receive):
 			if r.clientMetrics.clientStreamRecvHistogramEnabled {
 				hist := r.clientMetrics.clientStreamRecvHistogram.WithLabelValues(string(r.typ), r.service, r.method)
 				return prometheus.NewTimer(hist)

diff --git a/interceptors/metrics/options.go → providers/prometheus/options.go b/interceptors/metrics/options.go → providers/prometheus/options.go
@@ -5,16 +5,6 @@ import (
 	"google.golang.org/grpc/status"
 )
 
-// Interface for Metrics
-type Metrics interface{}
-
-type Kind string
-
-const (
-	KindClient Kind = "client"
-	KindServer Kind = "server"
-)
-
 // Helper methods
 func FromError(err error) (s *status.Status, ok bool) {
 	return status.FromError(err)

diff --git a/interceptors/metrics/server_metrics.go → providers/prometheus/server_metrics.go b/interceptors/metrics/server_metrics.go → providers/prometheus/server_metrics.go