Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect initialization for data with only developmental responses #33

Closed
stefvanbuuren opened this issue May 7, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@stefvanbuuren
Copy link
Member

JAMES 1.6.0 incorrectly shows the chart for 0-15m height when the JSON data contain only developmental data. We could get the correct chart by pressing one of the controls. The expected behavior is that JAMES selects the correct chart right away.

Interactive example for v1.6.0: Run https://tnochildhealthstatistics.shinyapps.io/james_tryout/, select "Groep: Test" and "Naam test: T25 Extreme D-score at start".

Reprex via code:

# Reproduce issue 33: Incorrect initialization for files containing
# developmental data only
# james 1.6.0
library(jamesclient)
library(jamesdemodata)
test25 <- system.file("extdata", "bds_v3.0", "test", "test25.json",
                      package = "jamesdemodata")
host <- "https://james.groeidiagrammen.nl"
r <- james_post(host = host, path = "/site/request/json",
                sitehost = host, txt = test25)
r$parsed
#> [1] "https://james.groeidiagrammen.nl/site?session=x094048ebfab4e0"
browseURL(r$parsed)

Created on 2024-05-07 with reprex v2.1.0

@stefvanbuuren stefvanbuuren added the bug Something isn't working label May 7, 2024
@stefvanbuuren stefvanbuuren changed the title Incorrect initialization for files containing developmental data only Incorrect initialization for data with only developmental responses May 7, 2024
stefvanbuuren added a commit that referenced this issue May 8, 2024
Improve chart side initialization when there are child data (#33)
@stefvanbuuren
Copy link
Member Author

Problem resolved in james 1.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant