Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set internal vars ahead of time #43

Merged
merged 1 commit into from
May 6, 2020
Merged

fix: set internal vars ahead of time #43

merged 1 commit into from
May 6, 2020

Conversation

aaarichter
Copy link

  • fix: set internal properties before _createStream() is called

erothman-groupon
erothman-groupon approved these changes May 6, 2020
View reviewed changes
Copy link

@erothman-groupon erothman-groupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaarichter aaarichter merged commit 7e06425 into master May 6, 2020
@aaarichter aaarichter deleted the fix branch May 6, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erothman-groupon erothman-groupon erothman-groupon approved these changes

Assignees
No one assigned
Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaarichter @erothman-groupon @i-tier-bot