Apply latest nlm generator #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
suggested changes
Jan 5, 2018
package.json
Outdated
| @@ -2,12 +2,16 @@ | |||
| "name": "shared-store", | |||
| "version": "2.2.1", | |||
| "description": "Keeping config data in sync", | |||
| "license": "BSD-3-Clause", | |||
| "license": { | |||
.travis.yml
Outdated
| 'on': | ||
| branch: master | ||
| node: '4' | ||
| - git config --global user.email "[email protected]" |
There was a problem hiding this comment.
For gofer these lines are gone - do we know why they stuck around here?
There was a problem hiding this comment.
Looking back, the generator update only removed their presence in default config etc, and did not handle their removal. I've been removing them manually as I've come across them.
There was a problem hiding this comment.
Ah, interesting. Not sure if it's worth adding to the generator. Hopefully there aren't that many still around (and it's not like they hurt anything).
|
Nice catches @jkrems . Ready for another look 👍 |
jkrems
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by a machine.
nlmis a tool for automating the release of node packages. There are some notable implications of usingnlm:nlmcan parse them.Additionally some standard dependency versions were enforced:
bluebird@^3.3.3lodash@^4.6.1/cc @groupon/itier