Apply latest nlm generator & upgrade to bluebird 3.x #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
force-pushed
the
apply-nlm-generator
branch
from
4bcab79 to
cac9301
Compare
|
LGTM, but the PR title is misleading given the other fixes in it. How about updating it to include a reference to bluebird changes? |
jkrems
changed the title
jkrems
added a commit
that referenced
this pull request
Mar 7, 2016
Apply latest nlm generator & upgrade to bluebird 3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by a machine.
nlmis a tool for automating the release of node packages. There are some notable implications of usingnlm:nlmcan parse them.Additionally some standard dependency versions were enforced:
lodash@^4.6.1bluebird@^3.3.3/cc @groupon/itier