chore: Apply latest nlm generator

.gitignore

@@ -1,3 +1,4 @@
+/package-lock.json
 /yarn.lock
 node_modules/
 /tmp

.travis.yml

@@ -1,16 +1,17 @@
 language: node_js
 node_js:
-  - '0.10'
-  - '4'
+  - 4.6.1
+  - 6.11.5
+  - 8.9.0
+deploy:
+  - provider: script
+    script: ./node_modules/.bin/nlm release
+    skip_cleanup: true
+    'on':
+      branch: master
+      node: 8.9.0
 before_install:
   - npm install -g npm@latest-2
 before_deploy:
-  - 'git config --global user.email "[email protected]"'
-  - 'git config --global user.name "Groupon"'
-deploy:
-  provider: script
-  script: ./node_modules/.bin/nlm release
-  skip_cleanup: true
-  'on':
-    branch: master
-    node: '4'
+  - git config --global user.email "[email protected]"
+  - git config --global user.name "Groupon"

CONTRIBUTING.md

@@ -1,4 +1,4 @@
-<!-- Generated by generator-nlm -->
+<!-- Generated by generator-js -->
 
 # Contributing
 
@@ -31,7 +31,7 @@ If you report a bug, please follow these guidelines:
 
 For small documentation changes, you can use [Github's editing feature](https://help.github.com/articles/editing-files-in-another-user-s-repository/).
 The only thing to keep in mind is to prefix the commit message with "docs: ".
-The detault commit message generated by Github will lead to a failing CI build.
+The default commit message generated by Github will lead to a failing CI build.
 
 For larger updates to the documentation
 it might be better to follow the [instructions for contributing code below](#contributing-code).
@@ -52,7 +52,7 @@ The general steps for creating a pull request are:
 1. If you're fixing a bug, be sure to write a test *first*.
    That way you can validate that the test actually catches the bug and doesn't pass.
 1. Make your changes to the code.
-   Remember to update the tests if you add new features or change behavior. 
+   Remember to update the tests if you add new features or change behavior.
 1. Run the tests via `npm test`. This will also run style checks and other validations.
    You might see errors about uncommitted files.
    This is expected until you commit your changes.

package.json

@@ -2,12 +2,16 @@
   "name": "shared-store",
   "version": "2.2.1",
   "description": "Keeping config data in sync",
-  "license": "BSD-3-Clause",
+  "license": {
+    "files": [
+      "src"
+    ]
+  },
   "main": "lib/shared-store.js",
   "homepage": "https://github.com/groupon/shared-store",
   "repository": {
     "type": "git",
-    "url": "git+ssh://git@github.com/groupon/shared-store"
+    "url": "https://github.com/groupon/shared-store"
   },
   "bugs": {
     "url": "https://github.com/groupon/shared-store/issues"

test/crash-recovery.test.coffee

@@ -22,6 +22,7 @@ describe 'Crash recovery', ->
   before (done) ->
     process.setMaxListeners(99) # repeated process.on('exit') blab warnings
     tmp.dir { unsafeCleanup: true }, (err, @tmpDir) => done(err)
+    return
 
   before ->
     # Write known broken config
@@ -47,6 +48,7 @@ describe 'Crash avoidance', ->
   before (done) ->
     process.setMaxListeners(99) # repeated process.on('exit') blab warnings
     tmp.dir { unsafeCleanup: true }, (err, @tmpDir) => done(err)
+    return
 
   before ->
     # Write invalid JSON config

test/latest-file.test.coffee

@@ -26,6 +26,7 @@ describe 'latestFile', ->
   before (done) ->
     @dir = path.join os.tmpdir(), DIR_NAME
     rimraf @dir, -> done()
+    return
 
   describe 'with non-existant directory', ->
     before ->

test/shared-store/error-handling.test.coffee

@@ -14,6 +14,7 @@ describe 'SharedStore (error handling)', ->
         tmp.dir { unsafeCleanup: true }, (err, tmpDirParam) ->
           tmpDir = tmpDirParam
           done(err)
+        return
 
       it 'will return the error through callback', (done) ->
         thrownError = false
@@ -30,6 +31,7 @@ describe 'SharedStore (error handling)', ->
           assert.equal 'This throws!', err.message
           done()
         null
+        return
 
     describe 'with a cache', ->
       tmpDir = null
@@ -41,6 +43,7 @@ describe 'SharedStore (error handling)', ->
             loader: -> Observable.just {data: 'tastic'}
           store.init (storeErr, data) ->
             done(storeErr)
+        return
 
       it 'will return the cache through callback & getCurrent', (done) ->
         thrownError = false
@@ -57,13 +60,15 @@ describe 'SharedStore (error handling)', ->
           assert.equal null, err
           done()
         null
+        return
 
   describe 'reading from a loader that throws an error after a successful read', ->
     tmpDir = null
     before (done) ->
       tmp.dir { unsafeCleanup: true }, (err, tmpDirParam) ->
         tmpDir = tmpDirParam
         done(err)
+      return
 
     it 'will return the error through event handler', (done) ->
       thrownError = false
@@ -84,3 +89,4 @@ describe 'SharedStore (error handling)', ->
       store.on 'err', (err) ->
         assert.equal '¡Ay, caramba!', err.message
         done()
+      return

test/shared-store/index.test.coffee

@@ -25,6 +25,7 @@ CHANGED_DATA =
 describe 'SharedStore', ->
   before (done) ->
     tmp.dir { unsafeCleanup: true }, (err, @tmpDir) => done(err)
+    return
 
   describe 'reading from multiple loaders', ->
     before (done) ->
@@ -35,6 +36,7 @@ describe 'SharedStore', ->
       fs.writeFile(
         @overrideFile, JSON.stringify(@initialOverrides), done
       )
+      return
 
     before (done) ->
       @store = new SharedStore {
@@ -51,6 +53,7 @@ describe 'SharedStore', ->
       }
       @store.init opt: 'value', (err, @initCallbackData) => done(err)
       null
+      return
 
     it 'returns the initial data', ->
       assert.deepEqual INITIAL_DATA, @store.getCurrent()
@@ -82,13 +85,15 @@ describe 'SharedStore', ->
           assert.deepEqual({ static: 'data' }, @passiveStore.getCurrent())
           done()
         ), 300
+        return
 
     describe 'after changing a file', ->
       before (done) ->
         @newOverrides = fromFile: CHANGED_DATA.fromFile
         fs.writeFile(
           @overrideFile, JSON.stringify(@newOverrides), done
         )
+        return
 
       before (done) -> setTimeout done, 300
 

test/shared-store/retry.test.coffee

@@ -9,6 +9,7 @@ SharedStore = require '../../'
 describe 'SharedStore (retry functionality)', ->
   before (done) ->
     tmp.dir { unsafeCleanup: true }, (err, @tmpDir) => done(err)
+    return
 
   describe 'reading from a loader with a single value', ->
     store = null
@@ -28,3 +29,4 @@ describe 'SharedStore (retry functionality)', ->
 
       assert.equal 2, metaCount
       done()
+      return