Expose evaluations and metrics #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreyEWood
approved these changes
Feb 24, 2025
Comment on lines
+1003
to
+1010
| """ | ||
| Get a specific evaluation for a detector | ||
|
|
||
| :param detector: the detector to get the evaluation for | ||
| :param evaluation_id: the evaluation id to get | ||
|
|
||
| :return: The DetectorEvaluation object | ||
| """ |
There was a problem hiding this comment.
I think the docstring here is wrong - it doesn't take an evaluation_id. It also returns a dict, should it be returning a DetectorEvaluation object?
|
|
||
| :param detector: the detector to get the metrics for | ||
|
|
||
| :return: The DetectorMetrics object |
There was a problem hiding this comment.
Same here about the return type.
| assert metrics["summary"]["unconfident_counts"] is not None | ||
| assert metrics["summary"]["total_iqs"] is not None | ||
|
|
||
| # NOTE: this implicitly tests how quickly the evaluation is made available |
There was a problem hiding this comment.
Is there any worry that this test will be flaky due to evaluation sometimes taking too long?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes metrics and evaluations available