Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #894 #896

Closed
wants to merge 1 commit into from
Closed

Fix issue #894 #896

wants to merge 1 commit into from

Conversation

Zardoz89
Copy link

@Zardoz89 Zardoz89 commented May 24, 2019

If <release> tag is present, ignores <source> and <target> tags. This allows to use <release> tag with a JDK >= 9

Additionally, shows on maven output, the Java release that would be using.

@pivotal-issuemaster
Copy link

@Zardoz89 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@Zardoz89 Thank you for signing the Contributor License Agreement!

@eric-milles
Copy link
Member

Thanks for the bug and PR. A new groovy-eclipse-compiler artifact should be available shortly.

@Zardoz89
Copy link
Author

I would keep getLogger().info(String.format("Compiling for Java %s release.", release )); as is usefull information when one use maven from console. But thanks for merging this.

@eric-milles
Copy link
Member

If you add <verbose>true</verbose> to your compiler's <configuration> element, you can see all the command line options being passed to the batch compiler, not just the release setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants