fixes of issues 625/626

[ybayk]

Fixes of
#625
#626

When a method being completed has a trailing closure and CLOSURE_NOPARENS preference is set, the following behavior is honored:

1. Regardless of CLOSURE_BRACKETS setting true or false, the proposed parameter for the trailing closure is going to be empty code block { } instead of { it } or argument name respectively.
2. Trailing closure parameter does not take part in the parameter switching (the linked mode).
3. For single-argument methods, the caret automatically moves inside the closure code block rather than to the end of replacement statement
4. For multi-argument methods, quitting the linked mode moves the caret automatically inside the closure code block rather than to the end of replacement statement

Note that behavior stays the same as before:

• for non-trailing closure parameters
• when CLOSURE_NOPARENS is off
• when closure completion is triggered by '{' character

[eric-milles]

Looks great. I made some minor style edits. I'm going to close 603, 625 and 626. If you want an additional change, would you be available for chat on Slack?

[ybayk]

Sure I am always on slack. Could you give me specific details on the channel to use?
By the way, I noticed that you work at Thomson Reuters. I used to be TR employee, was a part of IP & Science which got sold to private investors a year ago to form Clarivate Analytics.

[eric-milles]

The groovy-eclipse channel if you have thoughts for all to see. Or you can DM me (eric-milles).

…

________________________________ From: ybayk <[email protected]> Sent: Friday, July 13, 2018 12:14 PM To: groovy/groovy-eclipse Cc: Milles, Eric (TR Technology & Ops); State change Subject: Re: [groovy/groovy-eclipse] fixes of issues 625/626 (#632) Sure I am always on slack. Could you give me specific details on the channel to use? By the way, I noticed that you work at Thomson Reuters. I used to be TR employee, was a part of IP & Science which got sold to private investors a year ago to form Clarivate Analytics. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_groovy_groovy-2Declipse_pull_632-23issuecomment-2D404896455&d=DwMFaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=tPJuIuL_GkTEazjQW7vvl7mNWVGXn3yJD5LGBHYYHww&m=rK_YeQ4BY6p_tTbP2x8HcTtRKQuopXHYl72GKZPJcVA&s=peyAVqiGw8fUZTZH6E-AhtRqICU-XeQXgkq0oAmZbDU&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ARWdisioXvd80EStP-2DVXquPgu3GmwaXYks5uGNV3gaJpZM4VODXh&d=DwMFaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=tPJuIuL_GkTEazjQW7vvl7mNWVGXn3yJD5LGBHYYHww&m=rK_YeQ4BY6p_tTbP2x8HcTtRKQuopXHYl72GKZPJcVA&s=WHe8Yk0bgFLcSH6Ehs6w958ayCRg9lCbo1nE8CiKjR0&e=>.