Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/groovy/groovy-eclipse/issues/600 #601

Merged
merged 2 commits into from
Jun 10, 2018
Merged

Conversation

ybayk
Copy link

@ybayk ybayk commented Jun 10, 2018

testAssignedVariable10 fails before the fix and passes after.

@eric-milles
Copy link
Member

Should the recovery exist for all forms of assignment? For example, foo += |

@eric-milles eric-milles merged commit 4688736 into groovy:master Jun 10, 2018
@eric-milles
Copy link
Member

I forgot to note that grammar changes are not re-built by the maven build. The changes to the recognizer, etc. must be included with the commit.

I have a commit coming in a couple minutes to fix this and add recovery for +=, etc. and to add error recovery tests.

eric-milles added a commit that referenced this pull request Jun 11, 2018
@ybayk
Copy link
Author

ybayk commented Jun 11, 2018

sorry, intentionally left other ops untreated as it was no use in AssignedVariable point-cut
also not clear what to do for antlr 4

@eric-milles
Copy link
Member

I have not applied any parser recovery to the Antlr4 grammar or plug-in. I made a couple attempts but have no working strategy at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants