Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing property suggestion in map-style constructor invocation code assist when such property is defined just by its setter #330

Closed
mauromol opened this issue Sep 1, 2017 · 2 comments

Comments

@mauromol
Copy link

mauromol commented Sep 1, 2017

This is a regression I discovered while re-testing the old GRECLIPSE-1772.

Consider the following:

package c
class MyBean {
	String foo
	void setBar(String bar) {
		foo = bar.toUpperCase()
	}
}

And:

package c
class ConstructorTest {
	static main(args) {
		MyBean b = new MyBean(|)
	}
}

Invoke code assist at "|": the property MyBean.bar is not suggested as a possible map-style constructor argument, only MyBean.foo is.

Also, I personally think that the code assist should not automatically add the trailing ",", I would find more comfortable to decide myself if I really need a comma (to enter another key-value pair).

@mauromol mauromol changed the title Missing property suggested in map-style constructor invocation code assist when such property is defined just by its setter Missing property suggestion in map-style constructor invocation code assist when such property is defined just by its setter Sep 1, 2017
@eric-milles
Copy link
Member

Could you give this a re-try with the latest build?

@mauromol
Copy link
Author

mauromol commented Sep 7, 2017

This use case seems to be fixed in 2.9.2.xx-201709052200-e46, thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants