Fix for issue #277: three error log entries when Buildship not installed

groovy · Apr 12, 2017 · 5bfc653 · 5bfc653
1 parent 0dcfc2a
commit 5bfc653
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/...s.groovy.eclipse.ui/src/org/codehaus/groovy/eclipse/ui/decorators/GroovyPluginImages.java b/...s.groovy.eclipse.ui/src/org/codehaus/groovy/eclipse/ui/decorators/GroovyPluginImages.java
@@ -31,15 +31,12 @@ private static ImageDescriptor createDescriptor(String path) {
     }
 
     private static ImageDescriptor createDescriptor2(String path) {
-        ImageDescriptor desc;
         try {
-            desc = ImageDescriptor.createFromURL(new java.net.URL(path));
-            org.eclipse.swt.graphics.Image img = desc.createImage(false);
-            if (img != null) { img.dispose(); } else { desc = null; }
+            java.net.URL url = new java.net.URL(path);
+            url.openConnection(); // does image exist?
+            return ImageDescriptor.createFromURL(url);
         } catch (Exception e) {
-            e.printStackTrace();
-            desc = null;
+            return null;
         }
-        return desc;
     }
 }