Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename component tokens to element tokens #4286

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Rename component tokens to element tokens #4286

merged 1 commit into from
Oct 28, 2024

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Oct 28, 2024

Deploy Preview

What does this PR do?

For clarity, we have decided to:

  • Rename "component" t-shirt size tokens to "element" tokens
  • Move "element" tokens into their own collection instead of nesting them within component-specific tokens.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit ba29d3f
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/671fe9345367920008969f7d
😎 Deploy Preview https://deploy-preview-4286--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taysea taysea merged commit 1e25fe2 into master Oct 28, 2024
9 of 11 checks passed
@taysea taysea deleted the element-tokens branch October 28, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant