Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design tokens alpha #4166

Merged
merged 299 commits into from
Sep 12, 2024
Merged

Add design tokens alpha #4166

merged 299 commits into from
Sep 12, 2024

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Sep 10, 2024

Deploy Preview

What does this PR do?

Merges "alpha" design tokens work in master. This includes:

  • design-tokens/ - houses all design token source files and scripts
  • design-tokens-manger/ - houses app for internal management of tokens (currently just docs of tokens/tree visualizer)
  • sandbox/ - apps consuming tokens

TO DO:

  • Prior to merge, Github actions flows should be adjusted to respond to any PRs that merge into "master" and affect design-tokens/ directory

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea marked this pull request as ready for review September 12, 2024 21:21
@taysea taysea merged commit 8a35159 into master Sep 12, 2024
8 of 10 checks passed
@taysea taysea deleted the design-tokens-alpha branch September 12, 2024 21:42
@taysea taysea restored the design-tokens-alpha branch September 12, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants