Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button guidance for Add, New, Create #3534

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Conversation

SeamusLeonardHPE
Copy link
Collaborator

@SeamusLeonardHPE SeamusLeonardHPE commented Sep 5, 2023

Updated button guidance as per recommendations on ticket #3496

Deploy Preview

What does this PR do?

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Closes #3496

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Notifications

[Update]Button

[When to use "Add", "Create", and "New"]

[Added guidance for when to use "Add", "Create", and "New" for button labels.]

Updated button guidance as per recommendations on ticket
#3496
@taysea taysea changed the title Update button.mdx Add button guidance for Add, New, Create Sep 14, 2023
@taysea taysea self-requested a review September 14, 2023 15:06
@taysea taysea merged commit d1fe3fe into master Sep 14, 2023
5 of 7 checks passed
@taysea taysea deleted the SeamusLeonardHPE-patch-1 branch September 14, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guidance on when to use 'add', 'create', and 'new'.
4 participants