Fix handling of nested paths #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancama2
approved these changes
Oct 9, 2019
cermakjiri
approved these changes
Oct 10, 2019
|
@aditbiswas1 how does it look like with the MR? I kinda need this to be merged. |
aditbiswas1
approved these changes
Nov 26, 2019
|
@aditbiswas1 we need one more to merge it, could you pls find someone? |
ashbhir
reviewed
Nov 26, 2019
| // expectations | ||
| expect(value.userId).toEqual(userId); | ||
| expect(value.auth.authToken).toEqual(authToken); | ||
| expect(value.auth.key).toEqual(key); |
There was a problem hiding this comment.
how is this test of auth.key any different from auth.authToken ?
There was a problem hiding this comment.
With the current version of the library this would fail since there is no deep merge.
jancama2
approved these changes
Nov 26, 2019
| // expectations | ||
| expect(value.userId).toEqual(userId); | ||
| expect(value.auth.authToken).toEqual(authToken); | ||
| expect(value.auth.key).toEqual(key); |
There was a problem hiding this comment.
With the current version of the library this would fail since there is no deep merge.
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes handling of nested paths at the cost of adding a dependency on Lodash.