Skip to content

revamp getStoreFromCookies fixing pending issues #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2019
Merged

revamp getStoreFromCookies fixing pending issues #51

merged 3 commits into from
Mar 24, 2019

Conversation

@ashbhir
Copy link
Contributor

@ashbhir ashbhir commented Mar 6, 2019

  • Adds ability to pass null or empty initial state
  • Avoid mutations in initial state
  • Ability to get non JSON values from cookies

@ashbhir ashbhir force-pushed the fix-getStoreFromCookies-implemetation branch from d96dd0d to cf239b6 Compare March 6, 2019 21:08
This was referenced Mar 6, 2019
Closed
Closed
@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 94.406% when pulling 8c712f6 on fix-getStoreFromCookies-implemetation into 361327a on master.

@coveralls
Copy link

coveralls commented Mar 7, 2019

Coverage Status

Coverage increased (+0.9%) to 94.406% when pulling d96dd0d on fix-getStoreFromCookies-implemetation into 6a73911 on master.

@coveralls
Copy link

coveralls commented Mar 7, 2019

Coverage Status

Coverage increased (+0.9%) to 94.406% when pulling cf239b6 on fix-getStoreFromCookies-implemetation into 6a73911 on master.

priyansh1161
priyansh1161 previously approved these changes Mar 14, 2019
View reviewed changes
@priyansh1161
Copy link
Contributor

priyansh1161 commented Mar 14, 2019

Please rebuild as well, as there are no changes in lib

@priyansh1161 priyansh1161 dismissed their stale review March 14, 2019 15:16

Please rebuild as well, as there are no changes in lib

@ashbhir ashbhir changed the base branch from master to bugfix-pathslicer March 22, 2019 17:59
@ashbhir ashbhir changed the base branch from bugfix-pathslicer to master March 22, 2019 17:59
ashbhir added 3 commits March 22, 2019 23:30
@ashbhir
ability to pass null or empty initial state
7ae6f17 
avoid mutations in initial state
ability to get non JSON values from cookies
@ashbhir
minor version bump
2846314
@ashbhir
generating lib folder
39e0065
@ashbhir ashbhir force-pushed the fix-getStoreFromCookies-implemetation branch 3 times, most recently from 8c712f6 to 39e0065 Compare March 22, 2019 18:11
@priyansh1161
Copy link
Contributor

priyansh1161 commented Mar 24, 2019 •
edited by anubhav7495
Loading

Approved

Approved with PullApprove

@priyansh1161 priyansh1161 merged commit 832ca27 into master Mar 24, 2019
@priyansh1161 priyansh1161 deleted the fix-getStoreFromCookies-implemetation branch March 24, 2019 11:48
@ashbhir
Copy link
Contributor Author

ashbhir commented Mar 25, 2019

This fixes Issues #49 #46

@ashbhir ashbhir mentioned this pull request Mar 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@anubhav7495 anubhav7495 anubhav7495 approved these changes

@priyansh1161 priyansh1161 priyansh1161 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashbhir @coveralls @priyansh1161 @anubhav7495