Re-design config_timezone for TZ + localtime handling + drop config_time #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file /etc/default/rcS no longer exists, and also /etc/adjtime doesn't necessarily exist any longer. Instead, even /etc/timezone is gone nowadays, see e.g. systemd/systemd#35413 We don't need to support the bootoption "utc" any longer, as this is the default nowadays. Don't invoke hwlock at all anymore, instead set /etc/localtime to the timezone requested via boot option tz=..., if set. Accordingly drop Depends on util-linux-extra, which we no longer need now with the hwclock removal. And use `timedatectl set-local-rtc 1` as interface for /etc/adjtime with its localtime handling. Drop $CONFIG_TIME + config_time with this cleanup and handle all of the remaining timezone handling within $CONFIG_TIMEZONE + config_timezone. Thanks to Chris and Darsha for the debugging session, and clarifying this.
zeha
approved these changes
Jan 30, 2025
|
JFTR, here are some older notes on this issue: grml/grml#61 + grml/grml-live@7f304b5 |
jkirk
approved these changes
Jan 30, 2025
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file /etc/default/rcS no longer exists, and also /etc/adjtime doesn't necessarily exist any longer.
Instead, even /etc/timezone is gone nowadays, see e.g. systemd/systemd#35413
We don't need to support the bootoption "utc" any longer, as this is the default nowadays.
Don't invoke hwlock at all anymore, instead set /etc/localtime to the timezone requested via boot option tz=..., if set. Accordingly drop Depends on util-linux-extra, which we no longer need now with the hwclock removal. And use
timedatectl set-local-rtc 1as interface for /etc/adjtime with its localtime handling.Drop $CONFIG_TIME + config_time with this cleanup and handle all of the remaining timezone handling within $CONFIG_TIMEZONE + config_timezone.
Thanks to @zeha and @jkirk for the debugging session, and clarifying this.