Sample test for SharedAxisTransition#1
Closed
shihaohong wants to merge 11 commits into
grinder15:fix/transition-widgets-child-state-creationfrom
shihaohong:transition-widgets-child-state-creation
Closed
Sample test for SharedAxisTransition#1shihaohong wants to merge 11 commits intogrinder15:fix/transition-widgets-child-state-creationfrom shihaohong:transition-widgets-child-state-creation
shihaohong wants to merge 11 commits into
grinder15:fix/transition-widgets-child-state-creationfrom
shihaohong:transition-widgets-child-state-creation
Conversation
…oning Transition widgets like FadeScaleTransition, FadeThroughTransition, and SharedAxisTransition is changing their subtree levels of widgets when transitioning causing the child state object to get recreated. CompositeAnimatedWidget solves the issue, instead of rebuilding animation widgets in AnimatedBuilder, it builds its transitions, stacked and only changing animation values to achieve different transitions on forward and reverse. Issue: flutter/flutter#53550
…/github.com/grinder15/packages into grinder15-fix/transition-widgets-child-state-creation
…/github.com/grinder15/packages into grinder15-fix/transition-widgets-child-state-creation
grinder15
force-pushed
the
fix/transition-widgets-child-state-creation
branch
from
19a57a0 to
4d3ab2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore the rest of the code changes, they seem to be since you haven't merged to
flutter/animations'smasterbranch in a while. Once you rebase/merge withflutter/animationsmaster, the rest of the file diffs should disappear. Or, you could just pick out the test I added and apply that directly to your branch.Take a look at the test starting from https://github.com/grinder15/packages/pull/1/files#diff-ca7f59dbfd46169f7fa7e5467a016f1aR1636 and let me know what you think! Apply that to the rest of the transition tests