Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching logic in Turbomole calculator #448

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 2, 2021

Was checking for any but should check for all coordinates

@awvwgk awvwgk added the bug Something isn't working label Mar 2, 2021
@awvwgk awvwgk added this to the v6.4.1 milestone Mar 2, 2021
@awvwgk awvwgk linked an issue Mar 2, 2021 that may be closed by this pull request
@awvwgk awvwgk changed the title Fix caching Logik in Turbomole calculator Fix caching logic in Turbomole calculator Mar 2, 2021
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #448 (40ae1b6) into master (943f424) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files         304      304           
  Lines       50792    50792           
=======================================
  Hits        20722    20722           
  Misses      30070    30070           
Impacted Files Coverage Δ
src/extern/turbomole.f90 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943f424...184a6cf. Read the comment docs.

@awvwgk awvwgk merged commit f6b888f into grimme-lab:master Mar 2, 2021
@awvwgk awvwgk deleted the cache-logic branch March 2, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization with xtb as Turbomole driver leads to translation
1 participant