Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection logic of command line flags #423

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jan 23, 2021

Fixes #389

@awvwgk awvwgk added the bug Something isn't working label Jan 23, 2021
@awvwgk awvwgk added this to the v6.4.0 milestone Jan 23, 2021
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #423 (b8b868a) into master (7be4776) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   40.74%   40.74%           
=======================================
  Files         304      304           
  Lines       50814    50814           
=======================================
  Hits        20705    20705           
  Misses      30109    30109           
Impacted Files Coverage Δ
src/prog/argparser.f90 79.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be4776...b8b868a. Read the comment docs.

@awvwgk awvwgk merged commit abf0c07 into grimme-lab:master Jan 23, 2021
@awvwgk awvwgk deleted the argparse branch January 23, 2021 17:19
tsitsvero added a commit to tsitsvero/xtb_prob that referenced this pull request Jan 25, 2021
Fix detection logic of command line flags (grimme-lab#423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problems parsing negative total charges on command line for charges <= -10
1 participant