Nitpicks. #1
Merged
Nitpicks. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My general rule is: use initializer lists except when you can't. Also, don't write empty constructors / destructors [unless the destructor actually needs to be virtual]. See here for an explanation: http://en.cppreference.com/w/cpp/language/rule_of_three The gist is: the compiler is required to generate these for you in the relevant cases. Also, class, struct, enum, and union definitions need a trailing semicolon. Function definitions do not.
it is almost certainly std::size_t. Technically, it is std::vector<T>::size_type. This may be relevant to your interests: http://en.cppreference.com/w/cpp/language/range-for
don't do this:
if (x == true)
return true;
else
return false;
do this instead:
return x;
Also, functions that always return true should just return void.
If an exceptional condition occurs, throw an exception.
|
Thanks a lot for this and the references! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You said you'd love feedback. Here's a bit to start.