Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign release with gpg key #86

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Sign release with gpg key #86

merged 1 commit into from
Nov 2, 2020

Conversation

nvthongswansea
Copy link
Member

Changes:

  • Add gpg signing in release GH workflow.

Required changes in repo's settings:

  • Add RELEASE_SIGNING_KEY as a secret variable, and put string content of the gpg private key in it.
  • Add RELEASE_SIGNING_KEY_PASSPHRASE as a secret variable, and put passphrase of the gpg private key in it.

bkircher
bkircher approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@bkircher bkircher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@bkircher bkircher merged commit 26cebb1 into master Nov 2, 2020
@bkircher bkircher deleted the gpgrelease branch November 2, 2020 15:40
@bkircher bkircher mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkircher bkircher bkircher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvthongswansea @bkircher