Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add network creation to gscloud #107

Merged
merged 1 commit into from
Jan 23, 2021
Merged

add network creation to gscloud #107

merged 1 commit into from
Jan 23, 2021

Conversation

MarcHarriss
Copy link
Member

closes #106

we still need to implement l2 security at some point, this just allows network creation /w name

@MarcHarriss MarcHarriss requested a review from bkircher January 19, 2021 20:25
bkircher
bkircher approved these changes Jan 23, 2021
View reviewed changes
Copy link
Contributor

@bkircher bkircher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🆒

@bkircher bkircher merged commit d132dcd into master Jan 23, 2021
@bkircher bkircher deleted the addNetworkCreate branch January 23, 2021 16:30
@bkircher
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkircher bkircher bkircher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable network creation
2 participants
@MarcHarriss @bkircher