Avoid leaving unclean state when using gscloud-server-create

[bkircher]

When server create fails somewhere in the middle of the whole thing it leaves objects behind that have already been created. This is unlike the panel which always cleans up nicely.

Panel uses POST /batch with

{
    "sub_calls": {
        "sub_calls": [
            {
                "call_type": "servers_post",
                "name": "ser1",
                "payload": {
                    "auto_recovery": true,
                    "availability_zone": null,
                    "cores": 1,
                    "hardware_profile": "q35",
                    "location_uuid": "8328a5bc-e66e-4edc-8aae-2e2bf07fdb28",
                    "memory": 1,
                    "name": "test-1"
                }
            },
            {
                "call_type": "storages_post",
                "name": "sto1",
                "payload": {
                    "capacity": 10,
                    "location_uuid": "8328a5bc-e66e-4edc-8aae-2e2bf07fdb28",
                    "name": "test-1",
                    "storage_type": "storage",
                    "template": {
                        "hostname": "test-1",
                        "password": "mysecret",
                        "password_type": "plain",
                        "template_uuid": "8d1bb5dc-7c37-4c90-8529-d2aaac75d812"
                    }
                }
            },
            {
                "call_type": "servers_storages_post",
                "name": "sto_x_ser",
                "payload": {
                    "bootdevice": true,
                    "server_uuid": "${SER1:SERVER_UUID}",
                    "storage_uuid": "${STO1:STORAGE_UUID}"
                }
            }
        ]
    }
}

to create a server. Not in API docs. You can observe this kind of behavior when user forgets to set --password in gscloud-server-create: new server object will be left while storage creation fails.

Ideas?

[bkircher]

We started work here on this branch in gsclient-go: https://github.com/gridscale/gsclient-go/tree/batch

[bkircher]

/batch API won't be supported by gsclient-go (gridscale/gsclient-go#176) So we have to come up with something here on the client side.

Something with defer that gets cancelled on the success path. Shouldn't be too hard.

[nvthongswansea]

@bkircher if you take a look at the "example" directory in gsclient-go package, you will see how to clean stuffs when there are errors during a process.