chore(www,ci): drop unsupported mac builds from downloads, template release notes #732
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Grida Desktop — Technical Preview | ||
|
|
||
| This is a nightly release of Grida `{{version}}`. | ||
|
|
||
| - macOS (signed, notarized) | ||
| - darwin arm64 — Apple Silicon | ||
| - dmg · zip | ||
| - linux | ||
| - deb · rpm | ||
| - arm64 · x64 | ||
| - windows (not signed) | ||
| - x64 | ||
|
|
||
| [Join Slack](https://grida.co/join-slack) to learn more. | ||
|
|
||
| ## Supported builds | ||
|
|
||
| | Name | Platform | x64 | arm64 | makers | signed | notes | | ||
| | ------- | -------- | --- | ----- | ---------------- | ------ | ------------------------------------------------------------------ | | ||
| | `Grida` | `darwin` | | ✓ | `zip`, `dmg` | ✓ | Apple Silicon only. Rosetta 2 cannot run arm64 binaries on Intel. | | ||
| | `Grida` | `win32` | ✓ | | `exe (squirrel)` | | x64 only / not signed | | ||
| | `Grida` | `linux` | ✓ | ✓ | `deb`, `rpm` | | | | ||
|
|
||
| ## Auto-update | ||
|
|
||
| macOS installs receive updates automatically via [`update.electronjs.org`](https://github.com/electron/update.electronjs.org). The running app polls every 6 hours; when a newer release is available, a "Restart to update" prompt appears. | ||
|
|
||
| Releases marked **pre-release** on this page are *not* served to existing installs — they're for manual download / testing only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,3 +100,16 @@ jobs: | |
| APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }} | ||
| APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }} | ||
| run: pnpm run publish:prerelease --arch="arm64" | ||
|
|
||
| - name: Update release notes from template | ||
| # Runs once (only on the macOS row) after the release tag has been | ||
| # created by the publisher. Template at .github/release-notes/desktop.md. | ||
| if: ${{ matrix.os.name == 'macos-apple-silicon' && env.HAS_SIGNING == 'true' && env.HAS_NOTARIZE == 'true' }} | ||
|
There was a problem hiding this comment.
The new release-notes step is conditioned on Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment. Good catch — applied in e207677. Re-gated the step to |
||
| working-directory: ${{ github.workspace }} | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| VERSION=$(node -p "require('./desktop/package.json').version") | ||
| TAG="v${VERSION}" | ||
| BODY=$(sed "s|{{version}}|${VERSION}|g" .github/release-notes/desktop.md) | ||
| gh release edit "$TAG" --notes "$BODY" --repo gridaco/grida | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new release-notes step is conditioned on
env.HAS_SIGNING == 'true' && env.HAS_NOTARIZE == 'true', so if Apple signing/notarization secrets are missing or temporarily unavailable, the Windows/Linux publish steps can still run and publish a release while this templating step is skipped. In that case the workflow reverts to empty/manual release bodies, which defeats the automation introduced here; this step should be gated only to a single matrix row (or another always-running path), not to mac signing availability.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — applied in e207677. Re-gated the step to
matrix.os.name == 'linux'(no signing-secret dependency, always runs). The release tag exists by the time linux's publish step finishes, so the body edit is safe.